On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote: > > > On 11/2/2020 5:34 PM, Pavana Sharma wrote: > >> How many times have i asked for you to add kerneldoc for this new > >> value? How many times have you not done so? > > > > I have added kerneldoc comment for the new value added. > > > >> NACK. > > > >> If you don't understand a comment, please ask. > > > > Ok, explain what do you expect by that comment. > > What Andrew wants you to do is add a comment like this: > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88
Hi Pavana This should also help: https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html And please compile the kernel with the W=1 flag. Make sure changes you make don't add new warnings. You will see a warning from this new enum valu you are adding because it is not correctly documented. Andrew
