On November 2, 2020 6:46:12 PM Kalle Valo <kv...@codeaurora.org> wrote:
Arend Van Spriel <arend.vanspr...@broadcom.com> writes:On November 2, 2020 6:15:32 PM Kalle Valo <kv...@codeaurora.org> wrote:Seung-Woo Kim <sw0312....@samsung.com> writes:There are missig brcmf_free() for brcmf_alloc(). Fix memory leak by adding missed brcmf_free(). Reported-by: Jaehoon Chung <jh80.ch...@samsung.com> Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions")This should be: Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and brcmf_detach() functions") But I can fix that, no need to resend because of this.Hi Kalle, But this is not the commit that needs fixing as I mentioned before. Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy during PCIe reset") which introduced the actual memory leak.I'll then change it to: Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset") Is that ok?
It is for me ;-) Regards, Arend
smime.p7s
Description: S/MIME Cryptographic Signature
