From: David Miller <[EMAIL PROTECTED]> Date: Thu, 26 Apr 2007 16:15:22 -0700 (PDT)
> Ok, I applied it all and added a compiler warning fix for 64-bit > at the end. I just found a problem in your work, you cannot use cmpxchg() in generic code, it is not available on all processors: [EMAIL PROTECTED]:~/src/GIT/net-2.6$ egrep cmpxchg fs/afs/*.c fs/afs/vlocation.c: if (cmpxchg(&vl->state, state, AFS_VL_CREATING) == [EMAIL PROTECTED]:~/src/GIT/net-2.6$ Also, cmpxchg() implementations typically only support 32-bit and 64-bit atomic operations, so even if this were allowed you'll get linking errors on sparc64 (and I think powerpc): WARNING: "__cmpxchg_called_with_bad_pointer" [fs/afs/kafs.ko] undefined! make[1]: *** [__modpost] Error 1 Anyways, please get me a patch to fix this, use a spinlock or the existing vl->lock rwlock. Something like that. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
