On Sun, Nov 01, 2020 at 01:43:34PM +0100, Heiner Kallweit wrote:
> I was wondering whether we have any policy on using EXPORT_SYMBOL or
> EXPORT_SYMBOL_GPL for newly exported functions. I've seen both options
> being used.
Hi Heiner
In the case of dev_get_tstats64() it is a trivial function to open
code in a driver. It is not going to cause any hardship for a closed
source out of tree network driver. So it makes no difference.
The existing stats functions in net/core/dev.c:
EXPORT_SYMBOL(netdev_stats_to_stats64);
EXPORT_SYMBOL(dev_get_stats);
EXPORT_SYMBOL_GPL(dev_fetch_sw_netstats);
so there is no general patterns to follow, pick whatever your want.
Andrew
