On Sat, 31 Oct 2020 22:41:30 +0100 Arnd Bergmann wrote: > On Sat, Oct 31, 2020 at 5:53 PM Jakub Kicinski <k...@kernel.org> wrote: > > > > On Fri, 30 Oct 2020 22:10:42 -0700 Xie He wrote: > > > > The usual way of getting rid of old code is to move it to staging/ > > > > for a few releases then delete it, like Arnd just did with wimax. > > > > > > Oh. OK. But I see "include/linux/if_frad.h" is included in > > > "net/socket.c", and there's still some code in "net/socket.c" related > > > to it. If we move all these files to "staging/", we need to change the > > > "include" line in "net/socket.c" to point to the new location, and we > > > still need to keep a little code in "net/socket.c". So I think if we > > > move it to "staging/", we can't do this in a clean way. > > > > I'd just place that code under appropriate #ifdef CONFIG_ so we don't > > forget to remove it later. It's just the dlci_ioctl_hook, right? > > > > Maybe others have better ideas, Arnd? > > I think it can just go in the bin directly.
Ack, fine by me. > I actually submitted a couple of patches to clean up drivers/net/wan > last year but didn't follow up with a new version after we decided > that x.25 is still needed, see > https://lore.kernel.org/netdev/20191209151256.2497534-1-a...@arndb.de/ > > I can resubmit if you like. Let's just leave it at DLCI/SDLA for now, we can revisit once Dave is back :)
