David Ahern <dsah...@gmail.com> writes:
> On 10/30/20 6:29 AM, Petr Machata wrote:
>> diff --git a/lib/utils.c b/lib/utils.c
>> index 930877ae0f0d..8deec86ecbcd 100644
>> --- a/lib/utils.c
>> +++ b/lib/utils.c
>> @@ -1763,3 +1763,11 @@ int parse_on_off(const char *msg, const char
>> *realval, int *p_err)
>>
>> return parse_one_of(msg, realval, values_on_off,
>> ARRAY_SIZE(values_on_off), p_err);
>> }
>> +
>> +void print_on_off_bool(FILE *fp, const char *flag, bool val)
>> +{
>> + if (is_json_context())
>> + print_bool(PRINT_JSON, flag, NULL, val);
>> + else
>> + fprintf(fp, "%s %s ", flag, val ? "on" : "off");
>> +}
>>
>
> I think print_on_off should be fine and aligns with parse_on_off once it
> returns a bool.
print_on_off() is already used in the RDMA tool, and actually outputs
"on" and "off", unlike this. So I chose this instead.
I could rename the RDMA one though -- it's used in two places, whereas
this is used in about two dozen instances across the codebase.
