On 30/10/2020 16:26, Willem de Bruijn wrote: > Then you could (as follow-up) advertise without GSO_PARTIAL and avoid > the whole transition through the gso layer?
The thing is, non-PARTIAL offload only supports tunnels that the NIC understands (single-layer UDP tunnels), but AIUI GSO_PARTIAL can support all sorts of other things, such as gretaps (though we'd need some more advertised features, I haven't figured out quite which ones yet but when I do and can test it I'll send a follow-up) and nested tunnels (as long as we don't need to edit the 'middle' IP ID, e.g. if it's DF or IPv6). So we definitely want to advertise GSO_PARTIAL support. But possibly I don't need to have NETIF_F_GSO_UDP_TUNNEL[_CSUM] in net_dev->gso_partial_features? -ed
