On Thu, Oct 29, 2020 at 4:13 PM Andrew Lunn <[email protected]> wrote:
> On Thu, Oct 29, 2020 at 02:52:52PM +0000, David Laight wrote:
> > From: Andrew Lunn
> > > Sent: 29 October 2020 14:31
>
> I think this trigraph issues popped up because of one of the changes
> you have in your playground, adding more warnings.
>
> What do you think of disabling the trigraph warning as well as
> disabling trigraphs themselves?
The trigraph warnings are currently disabled in mainline, and trigraphs
themselves are disabled in GCC unless explicitly enabled.
My series contained a patch that changes all trigraphs by adding
'\' characters, to let us no longer disable the warning and slightly
simplify the command line:
drivers/atm/idt77252.c | 2 +-
drivers/gpu/drm/msm/msm_rd.c | 2 +-
drivers/mtd/maps/sun_uflash.c | 2 +-
drivers/net/ethernet/marvell/mvneta.c | 2 +-
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +-
drivers/s390/block/dasd_proc.c | 2 +-
drivers/scsi/imm.c | 4 ++--
drivers/scsi/ppa.c | 4 ++--
drivers/tty/serial/sunsu.c | 2 +-
net/rose/af_rose.c | 4 ++--
sound/isa/msnd/msnd.c | 2 +-
Sorry you ran into this after you picked up the patches to the
Makefile but not my preparation patch.
I was unsure about whether this is worth changing, so I did not
send that one patch from my series and we can probably just
not drop the -Wno-trigraphs flag.
Arnd
