On 10/27/20 3:39 PM, Guillaume Nault wrote: > On Tue, Oct 27, 2020 at 10:28:29AM -0700, Cong Wang wrote: >> On Mon, Oct 26, 2020 at 4:23 AM Guillaume Nault <gna...@redhat.com> wrote: >>> >>> TCA_MPLS_ACT_PUSH and TCA_MPLS_ACT_MAC_PUSH might be used on gso >>> packets. Such packets will thus require mpls_gso.ko for segmentation. >> >> Any reason not to call request_module() at run time? > > So that mpls_gso would be loaded only when initialising the > TCA_MPLS_ACT_PUSH or TCA_MPLS_ACT_MAC_PUSH modes? > > That could be done, but the dependency on mpls_gso wouldn't be visible > anymore with modinfo. I don't really mind, I just felt that such > information could be important for the end user. >
I think the explicit dependency via modinfo is better.