On Tue, Oct 13, 2020 at 03:18:58PM +1300, Chris Packham wrote: > Implement serdes_power, serdes_get_lane and serdes_pcs_get_state ops for > the MV88E6097 so that ports 8 & 9 can be supported as serdes ports and > directly connected to other network interfaces or to SFPs without a PHY. > > Signed-off-by: Chris Packham <chris.pack...@alliedtelesis.co.nz> > --- > > This should be usable for all variants of the 88E6185 that have > tri-speed capable ports (which is why I used the mv88e6185 prefix > instead of mv88e6097). But my hardware only has a 88e6097 so I've only > connected up the ops for that chip. > > drivers/net/dsa/mv88e6xxx/chip.c | 61 ++++++++++++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > > diff --git a/drivers/net/dsa/mv88e6xxx/chip.c > b/drivers/net/dsa/mv88e6xxx/chip.c > index 1ef392ee52c5..1c6cd5c43eb1 100644 > --- a/drivers/net/dsa/mv88e6xxx/chip.c > +++ b/drivers/net/dsa/mv88e6xxx/chip.c > @@ -3436,6 +3436,64 @@ static int mv88e6xxx_set_eeprom(struct dsa_switch *ds, > return err; > } > > +static int mv88e6185_serdes_power(struct mv88e6xxx_chip *chip, int port, u8 > lane, > + bool up) > +{ > + /* The serdes power can't be controlled on this switch chip but we need > + * to supply this function to avoid returning -EOPNOTSUPP in > + * mv88e6xxx_serdes_power_up/mv88e6xxx_serdes_power_down > + */
Hi Chris How about bit 11 of the control register 0? This looks a lot like a BMCR, and BMCR_PDOWN. This is what mv88e6352_serdes_power() does. You might be able to even re-use it, if you can make the lane numbers work. Andrew