On 2020-10-16 12:42 p.m., Vlad Buslov wrote:
All action print callbacks have arg==NULL check and return at the beginning. To print action type we need either to have dedicated 'brief_dump' callback instead of reusing print_aop() or extend/refactor print_aop() implementation for all actions to always print the type before checking the arg. What do you suggest?
Either one sounds appealing - the refactoring feels simpler as opposed to a->terse_print(). BTW: the action index, unless i missed something, is not transported from the kernel for terse option. It is an important parameter when actions are shared by filters (since they will have the same index). Am i missing something? cheers, jamal
