On Wed, Oct 14, 2020 at 08:14:04AM +0300, Maxim Kochetkov wrote:
> The VSC9953 Seville switch has 2 megabits of buffer split into 4360
> words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabytes.
~~~~~~~~~
megabits
> 2 megabytes is (2048 / 8) * 1024 = 256 * 1024.
~~~~~~~~~ ^
megabits bytes
>
> Signed-off-by: Maxim Kochetkov <[email protected]>
> Fixes: a63ed92d217f ("net: dsa: seville: fix buffer size of the queue system")
> ---
Others:
Can you please use a different commit message? Like
"net: dsa: seville: the packet buffer is 2 megabits, not megabytes"
It simplifies the work of backporters to not have more than 1 commit
with the same title.
> drivers/net/dsa/ocelot/seville_vsc9953.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/ocelot/seville_vsc9953.c
> b/drivers/net/dsa/ocelot/seville_vsc9953.c
> index 9e9fd19e1d00..e2cd49eec037 100644
> --- a/drivers/net/dsa/ocelot/seville_vsc9953.c
> +++ b/drivers/net/dsa/ocelot/seville_vsc9953.c
> @@ -1010,7 +1010,7 @@ static const struct felix_info seville_info_vsc9953 = {
> .vcap_is2_keys = vsc9953_vcap_is2_keys,
> .vcap_is2_actions = vsc9953_vcap_is2_actions,
> .vcap = vsc9953_vcap_props,
> - .shared_queue_sz = 2048 * 1024,
> + .shared_queue_sz = 256 * 1024,
I suppose I haven't caught this because I've been running with this
patch in my tree:
https://patchwork.ozlabs.org/project/netdev/patch/[email protected]/
> .num_mact_rows = 2048,
> .num_ports = 10,
> .mdio_bus_alloc = vsc9953_mdio_bus_alloc,
> --
> 2.27.0
