On Sun, Oct 11, 2020 at 10:03 PM <[email protected]> wrote: > > From: Tonghao Zhang <[email protected]> > > Allow user configuring RXCSUM separately with ethtool -K, > reusing the existing virtnet_set_guest_offloads helper > that configures RXCSUM for XDP. This is conditional on > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS. > > If Rx checksum is disabled, LRO should also be disabled. > > Cc: Michael S. Tsirkin <[email protected]> > Cc: Jason Wang <[email protected]> > Cc: Willem de Bruijn <[email protected]> > Signed-off-by: Tonghao Zhang <[email protected]> > Acked-by: Michael S. Tsirkin <[email protected]>
Acked-by: Willem de Bruijn <[email protected]> I had to recall why we cannot just rely on dev->features and dev->hw_features to encode the set of feature capabilities, but need guest_offloads_capable. Flag NETIF_F_LRO encapsulates multiple VIRTIO_NET_F_GUEST_.. flags, and a device may advertise a subset. We thus have to bound to the set learned at probing time.
