On 2020-10-08 19:58 +0800, Coiby Xu wrote: > The debugging code in the following ifdef land > - QL_ALL_DUMP > - QL_REG_DUMP > - QL_DEV_DUMP > - QL_CB_DUMP > - QL_IB_DUMP > - QL_OB_DUMP > > becomes unnecessary because, > - Device status and general registers can be obtained by ethtool. > - Coredump can be done via devlink health reporter. > - Structure related to the hardware (struct ql_adapter) can be obtained > by crash or drgn. > > Suggested-by: Benjamin Poirier <benjamin.poir...@gmail.com> > Signed-off-by: Coiby Xu <coiby...@gmail.com> > --- > drivers/staging/qlge/qlge.h | 82 ---- > drivers/staging/qlge/qlge_dbg.c | 688 ---------------------------- > drivers/staging/qlge/qlge_ethtool.c | 2 - > drivers/staging/qlge/qlge_main.c | 7 +-
Please also update drivers/staging/qlge/TODO accordingly. There is still a lot of debugging code IMO (the netif_printk statements - kernel tracing can be used instead of those) but this patch is a substantial improvement.
