Sorry, hat to run out earlier and forgot to comment here. On Tue, 2020-10-06 at 14:32 +0200, Johannes Berg wrote: > > + /* the max policy content is currently ~44 bytes for range min/max */ > + if (err && nlk_has_extack && extack && extack->policy) > + tlvlen += 64;
So I'm not really happy with this. I counted 44 bytes content (so 48 bytes for the nested attribute) for the biggest that we have now, but if we ever implement e.g. dumping out the reject string for NLA_REJECT (though not sure anyone even uses that?) then it'd be more variable. I couldn't really come up with any better idea, but I believe we do need to size the skb fairly well to return the original one ... The only solution I _could_ think of was to allocate another skb, put the attribute into it, check the length, and then later append it to the message ... but that seemed kinda ugly. Any preferences? johannes
