On Mon, 2020-10-05 at 12:34 -0700, Jakub Kicinski wrote: > > > My thinking is that there are no known uses of the cookie, it'd only
Ahh. I completely misinterpreted the word "uses" here - you meant, I think (now), "uses of the cookie in the way that it was done in ethtool before". I read over this because it seemed in a way obviously right and also obviously wrong (no other uses of the cookie in ethtool and clearly uses of the cookie elsewhere, respectively)... > Right, I was commenting on the need to keep the cookie for backward > compat. Right ... > My preference is to do a policy dump to check the capabilities of the > kernel rather than shoot messages at it and then try to work backward > based on the info returned in extack. I guess Michal disagrees ;-) I can see both points of view though - if you have just a single attribute it's basically the same, but once you have two or more it's way less complex to just query before, I'd think. johannes
