On Fri, 2 Oct 2020 18:41:43 -0500 Rob Herring <r...@kernel.org> wrote:
> Another round of wack-a-mole. The json-schema default is additional > unknown properties are allowed, but for DT all properties should be > defined. > > Cc: Thierry Reding <thierry.red...@gmail.com> > Cc: Linus Walleij <linus.wall...@linaro.org> > Cc: Stephen Boyd <sb...@kernel.org> > Cc: Shawn Guo <shawn...@kernel.org> > Cc: Bjorn Andersson <bjorn.anders...@linaro.org> > Cc: Baolin Wang <baolin.wa...@gmail.com> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Jonathan Cameron <ji...@kernel.org> > Cc: Mauro Carvalho Chehab <mche...@kernel.org> > Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Cc: Lee Jones <lee.jo...@linaro.org> > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Bjorn Helgaas <bhelg...@google.com> > Cc: Vinod Koul <vk...@kernel.org> > Cc: Liam Girdwood <lgirdw...@gmail.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Daniel Lezcano <daniel.lezc...@linaro.org> > Cc: linux-...@vger.kernel.org > Cc: dri-de...@lists.freedesktop.org > Cc: linux-...@vger.kernel.org > Cc: linux-g...@vger.kernel.org > Cc: linux-hw...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: openipmi-develo...@lists.sourceforge.net > Cc: linux-l...@vger.kernel.org > Cc: linux-me...@vger.kernel.org > Cc: linux-rockc...@lists.infradead.org > Cc: linux-st...@st-md-mailman.stormreply.com > Cc: linux-m...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-...@vger.kernel.org > Cc: linux...@vger.kernel.org > Cc: linux-remotep...@vger.kernel.org > Cc: linux-ser...@vger.kernel.org > Cc: alsa-de...@alsa-project.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring <r...@kernel.org> > --- Hi Rob, Acked-by: Jonathan Cameron <jonathan.came...@huawei.com> # for iio However, one of these made me wonder if the binding was simply wrong... (definitely highlights why we should have additionalProperties: false where ever possible). ... > diff --git > a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > index abd8d25e1136..4c1c083d0e92 100644 > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > @@ -47,11 +47,17 @@ properties: > vddio-supply: > description: Regulator that provides power to the bus > > + spi-max-frequency: true > + spi-cpha: true > + spi-cpol: true It isn't completely unheard of for a device to operate in multiple SPI modes, but it does seem to be fairly unusual. I took a look at the datasheet and at least from the provided timing diagrams, these are both required in SPI mode. http://invensense.tdk.com/wp-content/uploads/2020/09/DS-000292-ICM-42605-v1.5.pdf That doesn't make the binding wrong as such, but we could be tighter in checking this! I'll add this to my list to take a closer look at sometime soonish. Thanks. Jonathan > + > required: > - compatible > - reg > - interrupts > > +additionalProperties: false > + > examples: > - |
