On Thu, 2020-10-01 at 12:21 -0700, David Miller wrote: > From: sa...@kernel.org > Date: Wed, 30 Sep 2020 19:05:02 -0700 > > > @@ -201,6 +206,9 @@ void mlx5_enter_error_state(struct > mlx5_core_dev *dev, bool force) > > err_detected = true; > > } > > mutex_lock(&dev->intf_state_mutex); > > + if (!mlx5_is_device_initialized(dev)) > > + return; > > + > > You can return with this mutex held, and that's ok? > > I think you have to "goto unlock;" or similar.
goto unlock is needed, thanks for spotting this, I will fix and send v2.
