On Wed, Sep 30, 2020 at 10:16:45PM +0300, Ioana Ciornei wrote: > +static int dpaa2_eth_dl_trap_action_set(struct devlink *devlink, > + const struct devlink_trap *trap, > + enum devlink_trap_action action, > + struct netlink_ext_ack *extack) > +{ > + /* No support for changing the action of an independent packet trap, > + * only per trap group - parser error drops > + */ > + return -EOPNOTSUPP;
Please also add an error message via extack > +}