On Sat, Sep 26, 2020 at 07:28:26PM +0200, Andrew Lunn wrote: > Hi Vladimir > > Just finishing off the next version of these patches, and i looped > back to check i addressed all the comments. > > This one i tend to disagree with. If you look at DSA drivers, a port > variable is always an integer index. dp is used to refer to a > dsa_port. > > If anything, i would suggest we rename dsa_to_port() to dsa_to_dp(), > and dsa_port_from_netdev to dsa_dp_from_netdev() or maybe > dsa_netdev_to_dp().
Maybe it's just me, but I don't like the "dp" name too much, and I think all conversions of those functions sound worse with the new names. But you do have a point with the inconsistency, so I suppose you could leave the name as it is? Or maybe dsa_dlp_to_port() if you fancy that abbreviation for a devlink port?
