From: Ben Greear <[EMAIL PROTECTED]> Date: Thu, 12 Apr 2007 14:45:07 -0700
> Andrew Morton wrote: > > > > Begin forwarded message: > > > > Date: Thu, 12 Apr 2007 21:50:00 +0200 (CEST) > > From: Jerome Borsboom <[EMAIL PROTECTED]> > > To: [EMAIL PROTECTED] > > Subject: [PATCH] allow VLAN interface on top of bridge interface > > > > > > When a VLAN interface is created on top of a bridge interface and > > netfilter is enabled to see the bridged packets, the packets can be > > corrupted when passing through the netfilter code. This is caused by the > > VLAN driver not setting the 'protocol' and 'nh' members of the sk_buff > > structure. In general, this is no problem as the VLAN interface is mostly > > connected to a physical ethernet interface which does not use the > > 'protocol' and 'nh' members. For a bridge interface, however, these > > members do matter. > > Why only do this inside that if clause? I can see only setting > nh.raw in that clause, but it seems like the protocol should be set > regardless. Because outside the if clause we are making the packet look like a normal ethernet frame to the rest of the stack, and only adding the VLAN tag at the very last moment in ->hard_start_xmit(). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
