> On Sep 23, 2020, at 12:31 PM, Andrii Nakryiko <andrii.nakry...@gmail.com>
> wrote:
>
> On Wed, Sep 23, 2020 at 9:55 AM Song Liu <songliubrav...@fb.com> wrote:
>>
>> This API supports new field cpu_plus in bpf_attr.test.
>>
>> Acked-by: John Fastabend <john.fastab...@gmail.com>
>> Signed-off-by: Song Liu <songliubrav...@fb.com>
>> ---
>> tools/lib/bpf/bpf.c | 13 ++++++++++++-
>> tools/lib/bpf/bpf.h | 11 +++++++++++
>> tools/lib/bpf/libbpf.map | 1 +
>> 3 files changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
>> index 2baa1308737c8..3228dd60fa32f 100644
>> --- a/tools/lib/bpf/bpf.c
>> +++ b/tools/lib/bpf/bpf.c
>> @@ -684,7 +684,8 @@ int bpf_prog_test_run(int prog_fd, int repeat, void
>> *data, __u32 size,
>> return ret;
>> }
>>
>> -int bpf_prog_test_run_xattr(struct bpf_prog_test_run_attr *test_attr)
>> +int bpf_prog_test_run_xattr_opts(struct bpf_prog_test_run_attr *test_attr,
>> + const struct bpf_prog_test_run_opts *opts)
>
> opts are replacement for test_attr, not an addition to it. We chose to
> use _xattr suffix for low-level APIs previously, but it's already
> "taken". So I'd suggest to go with just bpf_prog_test_run_ops and
> have prog_fd as a first argument and then put all the rest of
> test_run_attr into opts.
Sounds good. I will update it this way.
[...]
