On Mon, Sep 21, 2020 at 09:42:10PM +0200, Andrew Lunn wrote: > On Mon, Sep 21, 2020 at 07:10:09PM +0000, Vladimir Oltean wrote: > > On Mon, Sep 21, 2020 at 09:03:27PM +0200, Andrew Lunn wrote: > > > Vladimir, could you implement the devlink DEVLINK_CMD_INFO_GET request > > > so we know what sort of device is exporting the regions, and hence > > > which pretty printers are relevant. > > > > Should I do that in this series or separately? > > Up to you. I added it as part of the regions patchset.
I was planning to add that only if I need to resend this series, otherwise I would go with a follow-on. > I need to know which particular device it is in order to decode the > registers correctly. For sja1105, the device id is part of the static config, so the region is self explanatory in that regard. But if we create a larger tool then it makes sense to report the device in DEVLINK_CMD_INFO_GET. Thanks, -Vladimir
