On 9/18/20 9:48 AM, Jakub Kicinski wrote: > On Fri, 18 Sep 2020 09:44:35 -0600 David Ahern wrote: >> On 9/16/20 1:42 PM, Jakub Kicinski wrote: >>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode >>> DEFAULT group default qlen 1000 >>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff >>> RX: bytes packets errors dropped overrun mcast >>> 6.04T 4.67G 0 0 0 67.7M >>> RX errors: length crc frame fifo missed >>> 0 0 0 0 7 >>> TX: bytes packets errors dropped carrier collsns >>> 3.13T 2.76G 0 0 0 0 >>> TX errors: aborted fifo window heartbeat transns >>> 0 0 0 0 6 >>> >>> After: >>> >>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode >>> DEFAULT group default qlen 1000 >>> link/ether 00:0a:f7:c1:4d:38 brd ff:ff:ff:ff:ff:ff >>> RX: bytes packets errors dropped missed mcast >>> 6.04T 4.67G 0 0 7 67.7M >>> RX errors: length crc frame fifo overrun >>> 0 0 0 0 0 >>> TX: bytes packets errors dropped carrier collsns >>> 3.13T 2.76G 0 0 0 0 >>> TX errors: aborted fifo window heartbeat transns >>> 0 0 0 0 6 >> >> changes to ip output are usually not allowed. > > Does that mean "no" or "you need to be more convincing"? :) > > JSON output is not changed. I don't think we care about screen > scrapers. If we cared about people how interpret values based > on their position in the output we would break that with every > release, no? >
In this case you are not adding or inserting a new column, you are changing the meaning of an existing column. It's an 'error' stat so probably not as sensitive. I do not have a strong religion on it since it seems to be making the error stat more up to date.
