On Fri, Sep 18, 2020 at 05:46:45PM +0200, Alexandre Belloni wrote: > On 18/09/2020 13:57:47+0300, Vladimir Oltean wrote: > > From: Vladimir Oltean <vladimir.olt...@nxp.com> > > > > Some definitions were likely copied from > > drivers/net/mdio/mdio-mscc-miim.c. > > > > They are not necessary, remove them. > > Seeing that the mdio controller is probably the same, couldn't > mdio-mscc-miim be reused?
Yeah, it probably can, but for 75 lines of code, is it worth it to butcher mdio-mscc-miim too? I'm not sure at what level that reuse should be. Should we pass it our regmap? mdio-mscc-miim doesn't use regmap.
