On 9/17/20 12:50 PM, Jacob Keller wrote:
On 9/16/2020 8:02 PM, Shannon Nelson wrote:
Add a timeout element to the DEVLINK_CMD_FLASH_UPDATE_STATUS
netlink message for use by a userland utility to show that
a particular firmware flash activity may take a long but
bounded time to finish. Also add a handy helper for drivers
to make use of the new timeout value.
UI usage hints:
- if non-zero, add timeout display to the end of the status line
[component] status_msg ( Xm Ys : Am Bs )
using the timeout value for Am Bs and updating the Xm Ys
every second
- if the timeout expires while awaiting the next update,
display something like
[component] status_msg ( timeout reached : Am Bs )
- if new status notify messages are received, remove
the timeout and start over
Signed-off-by: Shannon Nelson <snel...@pensando.io>
---
This one looks good to me. I think the only other things that I saw from
previous discussion are:
a) we could convert the internal helper devlink_nl_flash_update_fill and
__devlink_flash_update_notify to use structs for their fields, and..
b) Jakub pointed out that most drivers don't currently use the component
field so we could remove that from the helpers.
However, I don't have strong feelings about those either way, so:
Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
Thanks,
sln
