Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.

Signed-off-by: Wang Xiaojun <wangxiaoju...@huawei.com>
---
 drivers/net/can/ti_hecc.c | 27 +++++----------------------
 1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index 94b1491b569f..d2712de34b74 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -857,7 +857,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
        struct net_device *ndev = (struct net_device *)0;
        struct ti_hecc_priv *priv;
        struct device_node *np = pdev->dev.of_node;
-       struct resource *res, *irq;
+       struct resource *irq;
        struct regulator *reg_xceiver;
        int err = -ENODEV;
 
@@ -878,39 +878,22 @@ static int ti_hecc_probe(struct platform_device *pdev)
        priv = netdev_priv(ndev);
 
        /* handle hecc memory */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hecc");
-       if (!res) {
-               dev_err(&pdev->dev, "can't get IORESOURCE_MEM hecc\n");
-               return -EINVAL;
-       }
-
-       priv->base = devm_ioremap_resource(&pdev->dev, res);
+       priv->base = devm_platform_ioremap_resource_byname(pdev, "hecc");
        if (IS_ERR(priv->base)) {
                dev_err(&pdev->dev, "hecc ioremap failed\n");
                return PTR_ERR(priv->base);
        }
 
        /* handle hecc-ram memory */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hecc-ram");
-       if (!res) {
-               dev_err(&pdev->dev, "can't get IORESOURCE_MEM hecc-ram\n");
-               return -EINVAL;
-       }
-
-       priv->hecc_ram = devm_ioremap_resource(&pdev->dev, res);
+       priv->hecc_ram = devm_platform_ioremap_resource_byname(pdev,
+                                               "hecc-ram");
        if (IS_ERR(priv->hecc_ram)) {
                dev_err(&pdev->dev, "hecc-ram ioremap failed\n");
                return PTR_ERR(priv->hecc_ram);
        }
 
        /* handle mbx memory */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbx");
-       if (!res) {
-               dev_err(&pdev->dev, "can't get IORESOURCE_MEM mbx\n");
-               return -EINVAL;
-       }
-
-       priv->mbx = devm_ioremap_resource(&pdev->dev, res);
+       priv->mbx = devm_platform_ioremap_resource_byname(pdev, "mbx");
        if (IS_ERR(priv->mbx)) {
                dev_err(&pdev->dev, "mbx ioremap failed\n");
                return PTR_ERR(priv->mbx);
-- 
2.25.1

Reply via email to