On 15/09/2020 02:44, Jesse Brandeburg wrote: > As part of the W=1 compliation series, these lines all created > warnings about unused variables that were assigned a value. Most > of them are from register reads, but some are just picking up > a return value from a function and never doing anything with it. > > The register reads should be OK, because the current > implementation of readl and friends will always execute even > without an lvalue. > > When it makes sense, just remove the lvalue assignment and the > local. Other times, just remove the offending code, and > occasionally, just mark the variable as maybe unused since it > could be used in an ifdef or debug scenario. > > Only compile tested with W=1. > > Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> For sfc/falcon: Acked-by: Edward Cree <ec...@solarflare.com>
- [PATCH net-next v2 09/10] sfc: fix kdoc warning Jesse Brandeburg
- [PATCH net-next v2 08/10] drivers/net/ethernet: remove in... Jesse Brandeburg
- [PATCH net-next v2 05/10] drivers/net/ethernet: rid ether... Jesse Brandeburg
- [PATCH net-next v2 07/10] drivers/net/ethernet: add some ... Jesse Brandeburg
- [PATCH net-next v2 01/10] i40e: prepare flash string in a... Jesse Brandeburg
- [PATCH net-next v2 06/10] drivers/net/ethernet: handle on... Jesse Brandeburg
- Re: [PATCH net-next v2 06/10] drivers/net/ethernet: ... Saeed Mahameed
- Re: [PATCH net-next v2 06/10] drivers/net/ethern... Jesse Brandeburg
- [PATCH net-next v2 04/10] drivers/net/ethernet: clean up ... Jesse Brandeburg
- Re: [PATCH net-next v2 04/10] drivers/net/ethernet: ... Edward Cree
- [PATCH net-next v2 02/10] intel-ethernet: clean up W=1 wa... Jesse Brandeburg
- [PATCH net-next v2 03/10] intel: handle unused assignment... Jesse Brandeburg
- Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W... Saeed Mahameed
- Re: [PATCH net-next v2 00/10] make drivers/net/ether... Andrew Lunn
- Re: [PATCH net-next v2 00/10] make drivers/net/e... Saeed Mahameed
- Re: [PATCH net-next v2 00/10] make drivers/n... Andrew Lunn
- Re: [PATCH net-next v2 00/10] make drivers/n... David Miller
- Re: [PATCH net-next v2 00/10] make drivers/net/ether... Jesse Brandeburg
- Re: [PATCH net-next v2 00/10] make drivers/net/ether... Jakub Kicinski
- Re: [PATCH net-next v2 00/10] make drivers/net/ethernet W... David Miller