On Mon, Sep 14, 2020 at 6:29 PM Willy Tarreau <w...@1wt.eu> wrote: > > On Mon, Sep 14, 2020 at 06:16:40PM +0200, Sedat Dilek wrote: > > On Mon, Sep 14, 2020 at 4:53 PM Amit Klein <aksecur...@gmail.com> wrote: > > > > > > Hi > > > > > > Is this patch being pushed to any branch? I don't see it deployed > > > anywhere (unless I'm missing something...). > > > > > > > It's here: > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise > > By the way I didn't get any feedback from those who initially disagreed > with the one that was mergd, so for now I'm not doing anything on it > anymore. I can propose it again for 5.10-rc1 but will not push anymore > if there's no interest behind it. >
As a feedback: Just some minutes ago... I have booted into Linux v5.9-rc5 with your (above mentioned) patchset plus some individual mostly Clang related patchset. While dealing with that topic, there was a "fast random" patchset from [1] offered in this context. I am not subscribed to any linux-random mailing-list, but I have this one included, too. Unsure, if there was any feedback on this. With WARN_ALL_UNSEEDED_RANDOM=y it reduces here the number of warnings. As a use-case I ran this PERF-SESSION... Link: https://github.com/ClangBuiltLinux/linux/issues/1086#issuecomment-675783804 /home/dileks/bin/perf list | grep prandom_u32 | column -t random:prandom_u32 [Tracepoint event] cd /opt/ltp echo 0 | tee /proc/sys/kernel/kptr_restrict /proc/sys/kernel/perf_event_paranoid /home/dileks/bin/perf record -a -g -e random:prandom_u32 ./runltp -f net.features -s tcp_fastopen /home/dileks/bin/perf report --no-children --stdio > ./perf-report.txt /home/dileks/bin/perf script > ./perf-script.txt echo 1 | tee /proc/sys/kernel/kptr_restrict /proc/sys/kernel/perf_event_paranoid I was curious (mostly) to see what the impact of tcp_conn_request() <-> prandom_u32() was and the improvements by the patch from Eric. I can send the perf-report.txt if desired. - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=random/fast
