On Fri, 11 Sep 2020 18:42:34 +0100 Edward Cree wrote: > > Should tso_version 3 be handled in this switch? > No, because this switch is in the EF10/Siena datapath and is neverrun for > EF100. Setting tx_queue->tso_version = 3 for EF100 is really just there > as documentation — EF100 has a completely different TX path, in > ef100_enqueue_skb(), which never looks at tx_queue->tso_version because > currently there's only one version of EF100 TSO descriptor. From a > functional perspective everything would still work if it were set to 0, > but that would be kinda misleading.
I see, that wasn't clear from file or function names. > Should I explain this in the commit message, or in a comment (and if the > latter, where should it go?) Yeah, won't hurt.
