On 9/11/2020 10:30 AM, Vladimir Oltean wrote:
On Thu, Sep 10, 2020 at 12:52:03PM -0700, Florian Fainelli wrote:
On 9/10/2020 9:48 AM, Vladimir Oltean wrote:
From: Vladimir Oltean <vladimir.olt...@nxp.com>
This reverts commit 314f76d7a68bab0516aa52877944e6aacfa0fc3f.
Citing that commit message, the call graph was:
dsa_slave_vlan_rx_add_vid dsa_port_setup_8021q_tagging
| |
| |
| +-------------+
| |
v v
dsa_port_vid_add dsa_slave_port_obj_add
| |
+-------+ +-------+
| |
v v
dsa_port_vlan_add
Now that tag_8021q has its own ops structure, it no longer relies on
dsa_port_vid_add, and therefore on the dsa_switch_ops to install its
VLANs.
So dsa_port_vid_add now only has one single caller. So we can simplify
the call graph to what it was before, aka:
dsa_slave_vlan_rx_add_vid dsa_slave_port_obj_add
| |
+-------+ +-------+
| |
v v
dsa_port_vlan_add
Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
I would be keen on keeping this function just because it encapsulates the
details of creating the switchdev object and it may be useful to add
additional functionality later on (like the DSA master RX VLAN filtering?),
but would not object to its removal if others disagree.
--
Florian
Hmm, I don't think there's a lot of value in having it, it's confusing
to have such a layered call stack, and it shouldn't be an exported
symbol any longer in any case.
Also, I already have a patch that calls vlan_vid_add(master) and having
this dsa_port_vid_add() helper doesn't save much at all.
OK, I am convinced:
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
--
Florian
