Re: [RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments

[Edward Cree]

On 11/09/2020 02:23, Jesse Brandeburg wrote:
> As part of the W=1 compliation series, these lines all created
> warnings about unused variables that were assigned a value. Most
> of them are from register reads, but some are just picking up
> a return value from a function and never doing anything with it.
>
> The register reads should be OK, because the current
> implementation of readl and friends will always execute even
> without an lvalue.
>
> When it makes sense, just remove the lvalue assignment and the
> local. Other times, just remove the offending code, and
> occasionally, just mark the variable as maybe unused since it
> could be used in an ifdef or debug scenario.
>
> Only compile tested with W=1 and an allyesconfig with all the
> network drivers turned into modules (to try to test all options).
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
For the sfc/falcon part:
Acked-by: Edward Cree <ec...@solarflare.com>
(it's not the same as the solution I went with for thevery
 similar code in the Siena driver (../farch.c), but it looks
 reasonable enough).