From: Petr Machata <[email protected]> Date: Thu, 10 Sep 2020 14:09:05 +0200
> The parameter passed via DCB_ATTR_DCB_BUFFER is a struct dcbnl_buffer. The > field prio2buffer is an array of IEEE_8021Q_MAX_PRIORITIES bytes, where > each value is a number of a buffer to direct that priority's traffic to. > That value is however never validated to lie within the bounds set by > DCBX_MAX_BUFFERS. The only driver that currently implements the callback is > mlx5 (maintainers CCd), and that does not do any validation either, in > particual allowing incorrect configuration if the prio2buffer value does > not fit into 4 bits. > > Instead of offloading the need to validate the buffer index to drivers, do > it right there in core, and bounce the request if the value is too large. > > CC: Parav Pandit <[email protected]> > CC: Saeed Mahameed <[email protected]> > Fixes: e549f6f9c098 ("net/dcb: Add dcbnl buffer attribute") > Signed-off-by: Petr Machata <[email protected]> > Reviewed-by: Ido Schimmel <[email protected]> > Reviewed-by: Jiri Pirko <[email protected]> Applied and queued up for -stable, thank you.
