On Thu, 10 Sep 2020 17:13:03 +0530 Vikas Singh wrote: > The function referred to (of_mdiobus_link_mdiodev()) is only built when > CONFIG_OF_MDIO is enabled, which is again, a DT specific thing, and would > not work in case of ACPI. > Given that it is a static function so renamed of_mdiobus_link_mdiodev() > as mdiobus_link_mdiodev() and did necessary changes, finally moved it out > of the #ifdef(CONFIG_OF_MDIO) therefore make it work for both DT & ACPI. > > Signed-off-by: Vikas Singh <vikas.si...@puresoftware.com>
nit: CHECK: braces {} should be used on all arms of this statement #60: FILE: drivers/net/phy/mdio_bus.c:461: + if (is_of_node(child)) { [...] + } else if (fwnode_property_read_u32(child, "reg", &addr)) [...]