Hi!
> > We already have different support for blinking in LED subsystem. Lets use
> > that.
>
> You are assuming we have full software control of the LED, we can turn
> it on and off. That is not always the case. But there is sometimes a
> mode which the hardware blinks the LED.
Please see "timer" trigger support in the LED subsystem. We already
have hardware-accelerated blinking for the LEDs, and phy LEDs should
use same mechanism.
> Being able to blink the LED is useful: ethtool(1): -p --identify
...and yes, it should work for ethtool, too.
See leds-ss4200.c: nasgpio_led_set_blink() for an example. (But it may
not be good example).
Best regards,
Pavel
