On Tue, Sep 08, 2020 at 11:00:41PM +0100, Russell King wrote:

> +static bool mvpp2_tx_hw_tstamp(struct mvpp2_port *port,
> +                            struct mvpp2_tx_desc *tx_desc,
> +                            struct sk_buff *skb)
> +{
> +     unsigned int mtype, type, i, offset;
> +     struct mvpp2_hwtstamp_queue *queue;
> +     struct ptp_header *hdr;
> +     u64 ptpdesc;
> +
> +     if (port->priv->hw_version == MVPP21 ||
> +         port->tx_hwtstamp_type == HWTSTAMP_TX_OFF)
> +             return false;
> +
> +     type = ptp_classify_raw(skb);
> +     if (!type)
> +             return false;
> +
> +     hdr = ptp_parse_header(skb, type);
> +     if (!hdr)
> +             return false;

At this point, the skb will be queued up to receive a transmit time
stamp, and so it should be marked with:

        skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;


The rest of the patch looks reasonable.

Acked-by: Richard Cochran <[email protected]>

Reply via email to