On Wed, Sep 9, 2020 at 9:22 AM Quentin Monnet <quen...@isovalent.com> wrote: > > eBPF selftests include a script to check that bpftool builds correctly > with different command lines. Let's add one build for bpftool's > documentation so as to detect errors or warning reported by rst2man when > compiling the man pages. Also add a build to the selftests Makefile to > make sure we build bpftool documentation along with bpftool when > building the selftests. > > This also builds and checks warnings for the man page for eBPF helpers, > which is built along bpftool's documentation. > > This change adds rst2man as a dependency for selftests (it comes with > Python's "docutils"). > > v2: > - Use "--exit-status=1" option for rst2man instead of counting lines > from stderr.
It's a sane default to have non-zero exit code on error/warning, so why not specifying it all the time? > - Also build bpftool as part as the selftests build (and not only when > the tests are actually run). > > Signed-off-by: Quentin Monnet <quen...@isovalent.com> > --- LGTM. Acked-by: Andrii Nakryiko <andr...@fb.com> > tools/testing/selftests/bpf/Makefile | 5 +++++ > .../selftests/bpf/test_bpftool_build.sh | 21 +++++++++++++++++++ > 2 files changed, 26 insertions(+) > [...]
