Hello.

Jeff Garzik wrote:

CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in the netpoll's "trapped" mode which easily causes overflows in the drivers with
short TX queues (most notably, in 8139too with its 4-deep queue).
Make this option more sensible by only bypassing TX softirq wakeup and remove CONFIG_NETPOLL_RX option completely since there is *no* code depending on it.

Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]>

ACK but (a) DaveM not me should apply this,

   Oops, sorry. But he's only mentioned as IPv4/v6 maintainer. :-)

and (b) I would check with netpoll people to see what that define is there for.

Amit Kale and I were already asking about CONFIG_NETPOLL_TRAP here 1+ months ago and got no replies. Well I'll try to CC Matt Mackall... If you mean CONFIG_NETPOLL_RX, there was #ifdef's in the early version of netpoll support:

http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commitdiff;h=8fb9cf8ab6c0ccb1b17b32c05dc9da3cc96ac229

but later they were removed but the option left:        

http://git.kernel.org/?p=linux/kernel/git/tglx/history.git;a=commitdiff;h=e3c265bcf67f21d847e970e71504890f61f37824

    Jeff

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to