On 9/8/20 8:39 AM, Jiri Pirko wrote: > Tue, Sep 08, 2020 at 11:10:18AM CEST, ido...@idosch.org wrote: >> From: Ido Schimmel <ido...@nvidia.com> >> >> Currently, the delete notification is emitted from the error path of >> nexthop_add() and replace_nexthop(), which can be confusing to listeners >> as they are not familiar with the nexthop. >> >> Instead, only emit the notification when the nexthop is actually >> deleted. The following sub-cases are covered: > > Well, in theory, this might break some very odd app that is adding a > route and checking the errors using this notification. My opinion is to > allow this breakage to happen, but I'm usually too benevolent :) >
That would be a very twisted app. No other notifications go out on failure to add / replace and nexthops should be consistent.
