On Mon, 7 Sep 2020 20:31:03 +0100 Edward Cree wrote: > On 07/09/2020 20:22, Jakub Kicinski wrote: > > On Mon, 7 Sep 2020 17:14:34 +0100 Edward Cree wrote: > >> drivers/net/ethernet/sfc/mcdi_port.c | 593 +------------------- > >> drivers/net/ethernet/sfc/mcdi_port_common.c | 560 ++++++++++++++++++ > > Would you mind improving variable ordering and addressing checkpatch > > complaints while moving this code? The camel case and breaking up > > case statements warning can definitely be ignored, but there are others. > I'd prefer to do it as a separate follow-up patch, so that git tools > can more reliably trace the history across the movement, per [1]. > If the series needs respinning then I'll add it in v2, otherwise I'll > post it standalone after this goes in.
Okay, applied, thanks!