On Fri, Aug 28, 2020 at 12:37 PM Stanislav Fomichev <[email protected]> wrote:
>
> From: YiFei Zhu <[email protected]>
>
> This syscall binds a map to a program. -EEXIST if the map is
> already bound to the program.
>
> Cc: YiFei Zhu <[email protected]>
> Signed-off-by: YiFei Zhu <[email protected]>
> Signed-off-by: Stanislav Fomichev <[email protected]>
> ---
> include/uapi/linux/bpf.h | 7 ++++
> kernel/bpf/syscall.c | 65 ++++++++++++++++++++++++++++++++++
> tools/include/uapi/linux/bpf.h | 7 ++++
> 3 files changed, 79 insertions(+)
>
[...]
> +
> + mutex_lock(&prog->aux->used_maps_mutex);
> +
> + used_maps_old = prog->aux->used_maps;
> +
> + for (i = 0; i < prog->aux->used_map_cnt; i++)
> + if (used_maps_old[i] == map) {
> + ret = -EEXIST;
> + goto out_unlock;
Do we need to return any error in this case? The intent of this
command is to make sure the map is bound to the prog, right? If it's
already bound, good, it's a success, just no extra steps were
performed internally. What's the use for this EEXIST if it's always
going to be ignored?
> + }
> +
> + used_maps_new = kmalloc_array(prog->aux->used_map_cnt + 1,
> + sizeof(used_maps_new[0]),
> + GFP_KERNEL);
> + if (!used_maps_new) {
> + ret = -ENOMEM;
> + goto out_unlock;
> + }
> +
[...]
