> +static void mvpp2_isr_handle_ptp_queue(struct mvpp2_port *port, int nq)
> +{
> +     void __iomem *ptp_q;
> +     u32 r0, r1, r2;
> +
> +     ptp_q = port->priv->iface_base + MVPP22_PTP_BASE(port->gop_id);
> +     if (nq)
> +             ptp_q += MVPP22_PTP_TX_Q1_R0 - MVPP22_PTP_TX_Q0_R0;
> +
> +     while (1) {
> +             r0 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R0) & 0xffff;
> +             if (!r0)
> +                     break;
> +
> +             r1 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R1) & 0xffff;
> +             r2 = readl_relaxed(ptp_q + MVPP22_PTP_TX_Q0_R2) & 0xffff;
> +     }
> +}

Hi Russell

That is a rather odd interrupt handler, basically throwing everything
away. Maybe add a comment about what is going on?

Reviewed-by: Andrew Lunn <and...@lunn.ch>

    Andrew

Reply via email to