> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Monday, August 24, 2020 1:41 PM > To: Nguyen, Anthony L <[email protected]> > Cc: [email protected]; Michael, Alice <[email protected]>; > [email protected]; [email protected]; [email protected]; > Kirsher, Jeffrey T <[email protected]>; Brady, Alan > <[email protected]>; Burra, Phani R <[email protected]>; Hay, > Joshua A <[email protected]>; Chittim, Madhu > <[email protected]>; Linga, Pavan Kumar > <[email protected]>; Skidmore, Donald C > <[email protected]>; Brandeburg, Jesse > <[email protected]>; Samudrala, Sridhar > <[email protected]> > Subject: Re: [net-next v5 11/15] iecm: Add splitq TX/RX > > On Mon, 24 Aug 2020 10:33:02 -0700 Tony Nguyen wrote: > > void iecm_get_stats64(struct net_device *netdev, > > struct rtnl_link_stats64 *stats) { > > - /* stub */ > > + struct iecm_vport *vport = iecm_netdev_to_vport(netdev); > > + > > + iecm_send_get_stats_msg(vport); > > Doesn't this call sleep? This .ndo callback can't sleep.
Will fix -Alan
