On 8/26/20 10:48 AM, Ido Schimmel wrote: > From: Ido Schimmel <ido...@nvidia.com> > > The code correctly uses nla_get_be32() to get the payload of the > attribute, but incorrectly uses nla_put_u32() to add the attribute to > the payload. This results in the following warning: > > net/ipv4/nexthop.c:279:59: warning: incorrect type in argument 3 (different > base types) > net/ipv4/nexthop.c:279:59: expected unsigned int [usertype] value > net/ipv4/nexthop.c:279:59: got restricted __be32 [usertype] ipv4 > > Suppress the warning by using nla_put_be32(). > > Signed-off-by: Ido Schimmel <ido...@nvidia.com> > --- > net/ipv4/nexthop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c > index d13730ff9aeb..0823643a7dec 100644 > --- a/net/ipv4/nexthop.c > +++ b/net/ipv4/nexthop.c > @@ -276,7 +276,7 @@ static int nh_fill_node(struct sk_buff *skb, struct > nexthop *nh, > case AF_INET: > fib_nh = &nhi->fib_nh; > if (fib_nh->fib_nh_gw_family && > - nla_put_u32(skb, NHA_GATEWAY, fib_nh->fib_nh_gw4)) > + nla_put_be32(skb, NHA_GATEWAY, fib_nh->fib_nh_gw4)) > goto nla_put_failure; > break; > >
Reviewed-by: David Ahern <dsah...@gmail.com>
