On 2020-08-25 17:49, Jakub Kicinski wrote:
On Tue, 25 Aug 2020 14:13:23 +0200 Björn Töpel wrote:
From: Björn Töpel <bjorn.to...@intel.com>
The page recycle code, incorrectly, relied on that a page fragment
could not be freed inside xdp_do_redirect(). This assumption leads to
that page fragments that are used by the stack/XDP redirect can be
reused and overwritten.
To avoid this, store the page count prior invoking xdp_do_redirect().
Fixes: efc2214b6047 ("ice: Add support for XDP")
Reported-and-analyzed-by: Li RongQing <lirongq...@baidu.com>
Signed-off-by: Björn Töpel <bjorn.to...@intel.com>
Gotta adjust the kdoc:
drivers/net/ethernet/intel/ice/ice_txrx.c:773: warning: Function parameter or
member 'rx_buf_pgcnt' not described in 'ice_can_reuse_rx_page'
drivers/net/ethernet/intel/ice/ice_txrx.c:885: warning: Function parameter or
member 'rx_buf_pgcnt' not described in 'ice_get_rx_buf'
drivers/net/ethernet/intel/ice/ice_txrx.c:1033: warning: Function parameter or
member 'rx_buf_pgcnt' not described in 'ice_put_rx_buf'
Thanks! I'll spin a v3.
