On Thu, Aug 20, 2020 at 9:52 AM David Miller <da...@davemloft.net> wrote: > > From: Tonghao Zhang <xiangxia.m....@gmail.com> > Date: Thu, 20 Aug 2020 07:21:33 +0800 > > > On Thu, Aug 20, 2020 at 6:52 AM David Miller <da...@davemloft.net> wrote: > > > >> From: xiangxia.m....@gmail.com > >> > >> Date: Tue, 18 Aug 2020 18:09:22 +0800 > >> > >> > >> > >> > Decrease table->count and ufid_count unconditionally, > >> > >> > >> > >> You don't explain why this is a valid transformation. > >> > >> > >> > >> Is it a bug fix? > > > > No > > > >> > >> > >> > >> Can it never happen? > >> > >> > >> > >> What are the details and how did you determine this? > > > > I want to simplify the codes, when flushing the flow, previous codes don't > > count the flow, because we have set them(flow counter/ufid counter)to 0. > > Now don't set counter and count flow and ufid flow when deleting them, and > > I add BUG_ON to make sure other patch no bug when flushing flow. > > Add these details to your commit message, please. Hi David v2 are sent, please review http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-2-xiangxia.m....@gmail.com/ http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-3-xiangxia.m....@gmail.com/ http://patchwork.ozlabs.org/project/netdev/patch/20200824073602.70812-4-xiangxia.m....@gmail.com/
-- Best regards, Tonghao
