> /* Set power up/down for 10GBASE-R and 10GBASE-X4/X2 */ > static int mv88e6390_serdes_power_10g(struct mv88e6xxx_chip *chip, u8 lane, > bool up) > @@ -678,8 +699,8 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, > int port, u8 lane, > case MV88E6XXX_PORT_STS_CMODE_2500BASEX: > err = mv88e6390_serdes_power_sgmii(chip, lane, up); > break; > - case MV88E6XXX_PORT_STS_CMODE_XAUI: > - case MV88E6XXX_PORT_STS_CMODE_RXAUI: > + case MV88E6XXX_PORT_STS_CMODE_XAUI: /* also > MV88E6393_PORT_STS_CMODE_5GBASER */ > + case MV88E6XXX_PORT_STS_CMODE_RXAUI: /* also > MV88E6393_PORT_STS_CMODE_10GBASER */ > err = mv88e6390_serdes_power_10g(chip, lane, up); > break; > }
Not so nice. Maybe add a m88e6393_serdes_power() function to avoid this? Andrew