On Thu, Aug 20, 2020 at 09:15:30AM -0700, Yonghong Song wrote: > > > On 8/20/20 8:07 AM, Jakub Kicinski wrote: > > On Wed, 19 Aug 2020 17:13:23 -0700 Yonghong Song wrote: > > > + fill_link_info = iter_link->tinfo->reg_info->fill_link_info; > > > + if (fill_link_info) > > > + return fill_link_info(&iter_link->aux, info); > > > + > > > + return 0; > > > > ERROR: code indent should use tabs where possible > > #138: FILE: kernel/bpf/bpf_iter.c:433: > > + return 0;$ > > > > WARNING: please, no spaces at the start of a line > > #138: FILE: kernel/bpf/bpf_iter.c:433: > > + return 0;$ > > > Thanks for reporting! Will wait a little bit for further > comments and send v2.
all looks good to me.
