From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 28 Mar 2007 07:30:32 +1000
> On Tue, Mar 27, 2007 at 02:57:18PM +0100, David Woodhouse wrote: > > > > > [IPV6]: Do not set IF_READY if device is down > > > > > > Now that we add the IPv6 device at registration time we don't need > > > to set IF_READY in ipv6_add_dev anymore because we will always get > > > a NETDEV_UP event later on should the device ever become ready. > > > > > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > > > This commit seems to have broken NetworkManager, which removes the > > link-local IPv6 address from each wireless interface while it's only > > intending to use it for scanning, then adds it back when it actually > > wants to _use_ the interface in question. > > Sorry, that patch is indeed broken. We do need to set IF_READY in > the case where all addresses were deleted (including the link-local) > and then recreated. The IPv6 device will be destroyed and recreated > too in that case. > > [IPV6]: Set IF_READY if the device is up and has carrier > > We still need to set the IF_READY flag in ipv6_add_dev for the case > where all addresses (including the link-local) are deleted and then > recreated. In that case the IPv6 device too will be destroyed and > then recreated. > > In order to prevent the original problem, we simply ensure that > the device is up before setting IF_READY. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Applied, thanks Herbert. I'll make sure to push this to the relevant -stable places. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
