On Wed, Aug 19, 2020 at 11:37:00AM +0100, Edward Cree wrote: > As far as I can tell, truncation to 32 bits is harmless ??? the > ??called function (efx_init_io) already tries every mask from the > ??passed one down to 32 bits in case of PCIe hardware limitations.
Which btw isn't needed. These days dma_set_mask_and_coherent and friends never fail because of a "too large" mask - it will only fail in the rare case of a too small one. So the two places that set the dma mask could be simplified.